[Bug 615695] Review Request: libaccounts-glib - Nokia Maemo Accounts base library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=615695

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de> 2010-07-22 14:09:59 EDT ---
The package looks almost fine to me. However, I recommend to be more specific
in the %file sections:

%files
%defattr(-,root,root,-)
%doc COPYING AUTHORS
%dir %{_datadir}/backup-framework/
%dir %{_datadir}/backup-framework/applications/
%{_libdir}/%{name}.so.*
%{_datadir}/backup-framework/applications/accounts.conf

%files devel
%defattr(-,root,root,-)
%{_libdir}/%{name}.so
%{_libdir}/pkgconfig/%{name}.pc
%{_includedir}/%{name}/

Also, file ChangeLog doesn't contain the changelogs but refers to running
git-log to get them. Thus, you should drop this file for now.

The SRPM referenced in the spec file is no longer available upstream. Instead
of extracting the tarball from a temporarily available SRPM, I suggest to get a
snapshot from the git repo.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.