[Bug 603233] Review Request: zeromq - Software library for fast, message-based applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603233

--- Comment #9 from Thomas Spura <tomspur at fedoraproject.org> 2010-07-23 07:18:43 EDT ---
Thanks for the review.

(In reply to comment #7)
> Suggestions
> 1) If package is needed only for F-13 and above then please follow
>   a) buildroot should be removed
Done
>   b) %clean not needed
Not done.
>   c) cleaning of buildroot at start of %install also not needed
Done

This is needed for F-13+ and EL-6+, so %clean needs to stay for now:
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

> 2) Please add some empty line between %package and %description sections for
> -devel and -utils subpackages 
Done
> 
> 3) %description for -devel packages are generally generic. See
> /etc/rpmdevtools/spectemplate-lib.spec
> So please replace existing %description text with following
> 
> The %{name}-devel package contains libraries and header files for 
> developing applications that use %{name}.
Done
> 
> 4) %description for -utils should be simple like
>  Utility files for libzmq package
> or
> This package contains ZeroMQ related utility files,
> e.g. zmq_forwarder, zmq_streamer and zmq_queue.
Done
> 
> 5) For me working Source URL is
> http://zeromq.wdfiles.com/local--files/area:download/zeromq-%{version}.tar.gz

What's wrong with:
http://www.zeromq.org/local--files/area:download/zeromq-%{version}.tar.gz ?

That url is used at: http://www.zeromq.org/area:download
and is working with spectool.

Wget changes my url to yours, when downloading, but what happends, when they
change the redirect somehow, e.g. to zeromp.wdfiles2.com?
I'd like to leave my url there...

Spec URL: http://tomspur.fedorapeople.org/review/zeromq.spec
SRPM URL: http://tomspur.fedorapeople.org/review/zeromq-2.0.7-4.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.