[Bug 617618] Review Request: perl-Carp-Always - Warn and die in Perl noisily with stack backtraces

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617618

manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review+

--- Comment #3 from manuel wolfshant <wolfy at nobugconsulting.ro> 2010-07-23 15:11:07 EDT ---
Maros, thank you for the informal review. PLease keep in mind that verifying
the source rpm via rpmlint is not enough, as files might get created/ modified
during the build process. See the issue on the README file below

Official review:


Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: devel/x86_64
 [x] Rpmlint output:
source RPM:
arp-Always.src: W: spelling-error Summary(en_US) backtraces -> backtracks, back
traces, back-traces
perl-Carp-Always.src: W: spelling-error %description -l en_US backtraces ->
backtracks, back traces, back-traces
perl-Carp-Always.src: W: spelling-error %description -l en_US ing -> ING, inf,
in
binary RPM:
perl-Carp-Always.noarch: W: spelling-error Summary(en_US) backtraces ->
backtracks, back traces, back-traces
perl-Carp-Always.noarch: W: spelling-error %description -l en_US backtraces ->
backtracks, back traces, back-traces
perl-Carp-Always.noarch: W: spelling-error %description -l en_US ing -> ING,
inf, in
perl-Carp-Always.noarch: W: file-not-utf8
/usr/share/doc/perl-Carp-Always-0.09/README
=> Lubomir, please convert the file and shutup rpmlint

 [x] Package is not relocatable.
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: same as Perl (Artistic or GPL+)
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package match the upstream source, as provided
in the spec URL.
     SHA1SUM of source file: 2e10b9bb6593f4e1c078911ccc1142c2598ea321 
/tmp/Carp-Always-0.09.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.
 [x] Final provides and requires are sane.
Requires:
perl >= 0:5.006
perl(:MODULE_COMPAT_5.12.1)
perl(Carp)
perl(strict)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
rpmlib(PayloadIsXz) <= 5.2-1

Provides:
perl(Carp::Always) = 0.09
perl-Carp-Always = 0.09-1.fc14

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [ ] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: koji scratch build/rawhide
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: koji scratch build/rawhide
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the test passes.

=== OPTIONAL ITEMS ===
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.

=== Issues ===
1. Please convert the generated README file to UTF-8.

================
*** APPROVED ***
================

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.