[Bug 226226] Merge Review: pam_passwdqc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226226

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-07-24 09:40:15 EDT ---
1) rpmlint reported
pam_passwdqc.src: W: spelling-error Summary(en_US) Pluggable -> Plug gable,
Plug-gable, Plugged
pam_passwdqc.src: W: spelling-error %description -l en_US pam -> map, Pam, pan
pam_passwdqc.src: W: spelling-error %description -l en_US passwdqc -> password,
passageway, passivised
pam_passwdqc.src: W: spelling-error %description -l en_US passwd -> passed
pam_passwdqc.src: W: spelling-error %description -l en_US passphrases -> pass
phrases, pass-phrases, paraphrases
pam_passwdqc.i686: W: spelling-error Summary(en_US) Pluggable -> Plug gable,
Plug-gable, Plugged
pam_passwdqc.i686: W: spelling-error %description -l en_US pam -> map, Pam, pan
pam_passwdqc.i686: W: spelling-error %description -l en_US passwdqc ->
password, passageway, passivised
pam_passwdqc.i686: W: spelling-error %description -l en_US passwd -> passed
pam_passwdqc.i686: W: spelling-error %description -l en_US passphrases -> pass
phrases, pass-phrases, paraphrases
==> This can be ignored.

2)timestamps should be preserved.Use INSTALL="install -p" when installing to
preserve timestamps.

3) I will suggest this pacakge to follow current packaging guidelines and
remove buildroot, %clean section and cleaning of build root in %install    

4) Should follow
https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.