[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #9 from Kevin Fenzi <kevin at tummy.com> 2010-07-24 16:02:11 EDT ---

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (GPL+ or artistic)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
e5fe8cd8894b2d66767e48f51779d778  Crypt-Cracklib-1.5.tar.gz
e5fe8cd8894b2d66767e48f51779d778  Crypt-Cracklib-1.5.tar.gz.orig

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
See below - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
See below - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
See below - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
OK - No rpmlint output. 
See below - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. You are disabling the internal dependency generator here, but not doing any
manual dependency generation. Why? I see no problems removing that line here. 

2. The: 
if [ ! "$RPM_BUILD_ROOT" = "/" ]
then

in install and clean sections should be removed. There are no longer required 
or wanted. ;) 

3. There seems to be a test suite here. Perhaps run it in %check?
See https://fedoraproject.org/wiki/Packaging/Perl#Testing_and_Test_Suites

4. You should include Changes and README as %doc files. Also, you may want 
to ask upstream to include a copy of the license. 

5. You need to own the %{perl_archlib}/Crypt/ directory here. 
Either change %{perl_archlib}/Crypt/Cracklib.pm to just %{perl_archlib}/Crypt/
or add a %dir%{perl_archlib}/Crypt to files. Likewise for the auto/Crypt dir.

6. rpmlint says: 

3 packages and 0 specfiles checked; 0 errors, 0 warnings.

7. Did you take an existing spec to create this one? If so, please do leave the 
old spec changelog entries to credit the orig author(s).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.