[Bug 616120] Review Request: spacecmd - Command-line interface to Spacewalk and Satellite servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=616120

--- Comment #5 from Maxim Burgerhout <maxim at wzzrd.com> 2010-07-24 17:05:40 EDT ---
Aron, I like the fact that you have moved the whole lot into site_packages.

I see you have changed the specfile to require just 'python'. This is not
necessary: the Python requirement is inserted by rpmbuild during creation of
the RPM in the form of python(abi). This works for both EL5 and F13, so the
'python' requirement can be taken out.

One more request is to add the -p flag to your install commands. I forgot about
this initially, sorry. This is to keep the original timestamps on the files you
install; see http://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps for
futher info. Take care to also keep the orignal timestamp on the source tarball
when building srpms.

Please upload the corrected spec and srpm files somewhere and provide a link to
them.

Am I right in assuming Miroslav is going to actually maintain this package when
it is approved?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.