[Bug 609142] Review Request: felix-main - Apache Felix Main

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=609142

Victor G. Vasilyev <victor.vasilyev at sun.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |615869

--- Comment #4 from Victor G. Vasilyev <victor.vasilyev at sun.com> 2010-07-25 09:51:09 EDT ---
Alexander, thanks for your valuable comments.

(In reply to comment #2)
> Do you really need the depmap? As all these dependencies are in Fedora now, are
> they missing proper poms/depmaps?
Wow! The depmap is really redundant. Thanks for the hint.
I've removed it from the spec file, and will change a default pattern in my
mind for maven packages. :-)

> Oh and one more thing why do you remove the parent?
> felix-parent is up for review
> https://bugzilla.redhat.com/show_bug.cgi?id=615868 you would better drop this
> part of the patch and BR it.    
(In reply to comment #3)
> Btw, https://bugzilla.redhat.com/show_bug.cgi?id=615869 felix-shell is also up
> for review should it depend on that bug too and remove that part of the patch?    
Unfortunately, both artifacts not in Fedora up to now, but I need to prepare
the NetBeans 6.9 feature for the F14 features freeze in-time.
Seems, adding of both TODOs in spec file and explicit dependencies upon the
bugs here is the best solution for now.

The third release is prepared for review:

Spec URL: http://victorv.fedorapeople.org/files/felix-main.spec
SRPM URL: http://victorv.fedorapeople.org/files/felix-main-2.0.5-3.fc14.src.rpm

Successful koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2349479

The rpmlint tool shows " 0 errors, 0 warnings" for all RPMs, including src.rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.