[Bug 607584] Review Request: wordgroupz - A vocabulary building application
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jul 26 16:15:19 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=607584
Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |mtasaka at ioa.s.u-tokyo.ac.jp
Flag| |fedora-review?
--- Comment #9 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-07-26 12:15:18 EDT ---
(In reply to comment #8)
> But, I didn't get why "Obsoletes" is unneeded. How will the older versions be
> removed then?
- "# rpm -F" "# rpm -U" "# yum update (upgrade)" all handles this
just as expected.
For 0.3b-2:
* Unneeded comments / macros in comments
-----------------------------------------------------------------
wordgroupz.src:13: W: macro-in-comment %{_tmppath}
wordgroupz.src:13: W: macro-in-comment %{name}
wordgroupz.src:13: W: macro-in-comment %{version}
wordgroupz.src:13: W: macro-in-comment %{release}
wordgroupz.src:20: W: macro-in-comment %{name}
-----------------------------------------------------------------
- These warnings are raised because macros are used in comment line
without being escaped. Macros are expanded even in comment lines
and this sometimes causes unexpected errors.
Please use %% instead of % in comment lines, or just remove
unneeded comment lines.
* Requires
- "Requires: gtk" matches none of the packages on Fedora so this
must be removed. Also, "Requires: gtk2" is unneeded
because pygtk2 requires gtk2.
* desktop file
- Again as I said in the previous comment, "Application" in "Categories"
item in %_datadir/applications/%name.desktop is redundant and should
be removed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list