[Bug 226225] Merge Review: pam_krb5

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226225

--- Comment #4 from Nalin Dahyabhai <nalin at redhat.com> 2010-07-26 15:33:30 EDT ---
Thank you for picking up this review!

(In reply to comment #1)
> 2)timestamps should be preserved.Use INSTALL="install -p" when installing to
> preserve timestamps.

Done.

> 3) I will suggest this package to follow current packaging guidelines and
> remove buildroot, %clean section and cleaning of build root in %install    

Okay, done.

> 4) Should follow
> https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make    

Done.

(In reply to comment #3)
> Also,
>  As per https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags ,
> please add comment in spec why you need extras flags.    

I think at the time (and this would have been quite a while ago) libtool wasn't
doing the right thing and building the contents of the module with -fPIC, but
it seems to be doing the right things now.  Removing the CFLAGS tweaks.

The changes are made in upstream git if you'd like to review them:
  http://git.fedorahosted.org/git/?p=pam_krb5.git;a=blob;f=pam_krb5.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.