[Bug 604331] Review Request: redshift - Adjusts the color temperature of your screen according to time of day

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604331

Miloš Komarčević <miloskomarcevic at netscape.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(miloskomarcevic at n |
                   |etscape.net)                |

--- Comment #5 from Miloš Komarčević <miloskomarcevic at netscape.net> 2010-07-26 17:31:13 EDT ---
Thanks a lot for the feedback Mamoru, and sorry for the brief absence.

(In reply to comment #3)
> * License
>   - As far as I checked the whole source code, the license tag should
>     be "GPLv3+".

Done

> * BuildRoot
>   - BuildRoot tag is no longer needed on Fedora:
>     https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
>     ! Note that on EPEL5 and below BuildRoot tag is still needed.

Will leave it in then in case this ever makes it into EPEL5

> * Naming of gtk subpackage
>   - Normally Fedora names gui related subpackage as "%{name}-gui" or
>     "%{name}-gtk", and the former (-gui) is more general if no other
>     gui backend (such as qt or so) is provided.

I thought about this already and, unless this is a hard requirement, decided it
was better to have it the same as the name of the binary to avoid confusion.

> * Python related (Build)Requires
>   - Currently your srpm won't build on Fedora 12 because of lacking
>     %python_sitelib definition. Please refer to:
>     https://fedoraproject.org/wiki/Packaging/Python#Macros

Done

>   - Please use "python2" or "python3" for (Build)Requires, c.f.
>     https://fedoraproject.org/wiki/Packaging/Python#BuildRequires

Done

> * Dependencies between subpackages
>   - Usually dependencies between binary rpms rebuilt from the same
>     srpm must be EVR(Epoch-Version-Release) specific:
>     https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package

Done

> * Make build.log more verbose
>   - Currently build.log does not show how linkage on the created binary
>     is done:
> ------------------------------------------------------
>    183    CCLD   redshift
>    184  make[3]: Leaving directory `/builddir/build/BUILD/redshift-1.4.1/src'
>    185  make[2]: Leaving directory `/builddir/build/BUILD/redshift-1.4.1/src'
> ------------------------------------------------------
>     Please add "V=1" to "make %{?_smp_mflags}".

Done

> * Timestamp
>   - Please consider to use
> ------------------------------------------------------
> make DESTDIR=%{buildroot} install INSTALL="install -p"
> ------------------------------------------------------
>     to keep timestamps on the installed files as much as possible.
>     This method usually works for Makefiles generated by recent
>     autotools.

Done

> * Desktop file
>   - When gui program is installed, the corresponding desktop file must be
>     properly installed:
>     https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files    

gtk-redshift is not an app, but a widget, so there should be no need for a
desktop file


http://kmilos.fedorapeople.org/redshift.spec
http://kmilos.fedorapeople.org/redshift-1.4.1-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.