[Bug 614298] Review Request: emacs-apel - A Portable Emacs Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614298

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-07-27 02:46:39 EDT ---

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2353361
+ rpmlint output for SRPM and for RPM.
emacs-apel.src: W: no-buildroot-tag
emacs-apel-el.noarch: W: spelling-error Summary(en_US) Elisp -> Elis, Lisp,
Elise
emacs-apel-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e
lisp, Elise
emacs-apel-el.noarch: W: obsolete-not-provided apel
emacs-apel-el.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

+ source files match upstream url (sha1sum)
089c18ae006df093aa2edaeb486bfaead6ac4918  apel-10.8.tar.gz
089c18ae006df093aa2edaeb486bfaead6ac4918  apel-10.8.tar.gz.srpm

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present which is not needed now.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Follow emacs addon packaging guidelines.
+ Not a GUI application

APPROVED.

Suggestions:
1)If package is needed only for F-13 and above then please follow
 a) %clean not needed
 b) cleaning of buildroot at start of %install also not needed

2) See http://koji.fedoraproject.org/koji/getfile?taskID=2353362&name=build.log
I think its good to ask upstream to follow new style in *.el files.

3) installing commands should preserve timestamps. Use
make install PREFIX=$RPM_BUILD_ROOT%{_prefix} \
        LISPDIR=$RPM_BUILD_ROOT%{_emacs_sitelispdir} INSTALL="install -p"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.