[Bug 618451] Review Request: gdb-heap - Extensions to gdb for debugging dynamic memory allocation
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jul 27 15:02:13 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=618451
Tom "spot" Callaway <tcallawa at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tcallawa at redhat.com
--- Comment #4 from Tom "spot" Callaway <tcallawa at redhat.com> 2010-07-27 11:02:12 EDT ---
The license tag should be:
License: LGPLv2+ and Python
Also, you're using mixed macros ($RPM_BUILD_ROOT vs %{buildroot}). I would
suggest that you standardize on the latter.
I'm a little concerned about the forced dependency on
/usr/lib/debug/lib*/ld-2.11.2.so.debug, as technically, the package that
provides it (glibc-debuginfo) is not part of the normal repositories, so this
package will not be installable without the user consciously enabling the
debuginfo repo.
Perhaps a cleaner approach would be for the command to check on invocation for
presence of that library, and if not found, prompt the user to run the
appropriate "debuginfo-install" command, similar to gdb's behavior when it hits
missing debuginfo during a debug run.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list