[Bug 619025] Review Request: python-dpkt - Simple packet creation/parsing python library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619025

--- Comment #1 from Chen Lei <supercyper1 at gmail.com> 2010-07-28 08:24:56 EDT ---
Some initial comments here:

1.
4%{?dist} can be resetted to 1%{?dist}
2.

%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
->
%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%endif

%python_sitelib is defined in rpm macros for F13/F14 and EL6.

3.
Group:          Development/Languages
->
Group:          Development/Libraries

Development/Languages is for python runtime(e.g. python python3) or
compilers(e.g. gcc clang) only.

4.

Provides: dpkt = 1.7-3
Obsoletes: dpkt < 1.7-3
->
Obsoletes: dpkt < 1.7-4

Since dpkt is a new package, we can safely remove provides here.

5.
I suggest to remove python from summary and description since package name
already indicates it's a python module.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.