[Bug 592579] Review Request: Frama-c - Framework for source code analysis of C software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592579

Chen Lei <supercyper1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |supercyper1 at gmail.com

--- Comment #47 from Chen Lei <supercyper1 at gmail.com> 2010-07-28 08:51:46 EDT ---
Some suggestions:

1. Why not package the latest version - frama-c-Boron-20100401 instead? 

2.I think Development/Libraries should be changed to Development/Tools.

3.
%{_datadir}/applications should not be listed in %file, you need to use
%{_datadir}/applications/*.desktop instead.

4.
I suggest to rename %{name}.desktop to %{name}-gui.desktop. Actually, frama-c
is a command line tool.

5.
ExcludeArch: PPC, PPC64, ARM, IA64, MIPS, S390

I think you should use ExclusiveArch:  alpha armv4l %{ix86} ia64 x86_64 ppc
sparc sparcv9 ppc64 instead to keep consistency with ocaml.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.