[Bug 619025] Review Request: python-dpkt - Simple packet creation/parsing python library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619025

--- Comment #2 from Yanko Kaneti <yaneti at declera.com> 2010-07-28 09:02:39 EDT ---
Thanks for the comments.

(In reply to comment #1)
> Some initial comments here:
> 
> 1.
> 4%{?dist} can be resetted to 1%{?dist}
> 2.

Did reset it while also removing the previous parts of the changelog

> %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
> distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> ->
> %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
> %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
> distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> %endif
> 
> %python_sitelib is defined in rpm macros for F13/F14 and EL6.

This is just compatibility cruft.
I have no plans to maintain this for anything other than F14+


> 3.
> Group:          Development/Languages
> ->
> Group:          Development/Libraries
> 
> Development/Languages is for python runtime(e.g. python python3) or
> compilers(e.g. gcc clang) only.

Changed.


> 4.
> 
> Provides: dpkt = 1.7-3
> Obsoletes: dpkt < 1.7-3
> ->
> Obsoletes: dpkt < 1.7-4
> 
> Since dpkt is a new package, we can safely remove provides here.

I have no plans to touch the already published F13 update so I think the
Provides should stay. and it makes rpmlint happy. Change both to 1.7-4


> 5.
> I suggest to remove python from summary and description since package name
> already indicates it's a python module.    

Done.

New 
Spec URL: http://declera.com/~yaneti/python-dpkt/python-dpkt.spec
SRPM URL: http://declera.com/~yaneti/python-dpkt/python-dpkt-1.7-1.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.