[Bug 618985] Review Request: Swift - XMPP client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=618985

--- Comment #2 from Michal Schmidt <mschmidt at redhat.com> 2010-07-28 09:17:33 EDT ---
%description should be longer.

Where does swift.xpm (Source2) come from?

You do not need to define "BuildRoot:..." anymore, rpmbuild will use a sane one
automatically (since F-10).
You do not need to clean the buildroot manually at the beginning of %install
(since F-10).
You do not need the %clean section either (since F-13).
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

It's good that you remove bundled libraries in %prep. Only why you do not
remove all of them? The "3rdParty" directory still contains:
Boost  CppUnit  DocBook  hippomocks.h  LCov

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.