[Bug 619025] Review Request: python-dpkt - Simple packet creation/parsing python library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619025

--- Comment #4 from Yanko Kaneti <yaneti at declera.com> 2010-07-28 09:31:35 EDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > Thanks for the comments.
> > (In reply to comment #1)
> > > Some initial comments here:
> 
> > > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
> > > distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> > > ->
> > > %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
> > > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
> > > distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> > > %endif
> > > 
> > > %python_sitelib is defined in rpm macros for F13/F14 and EL6.
> > This is just compatibility cruft.
> This part is changed in packaging guideline already. Since you only maintain
> dpkt for F13+, I suggest you to remove the following lines from spec which is
> useless for F13 and above:
> 
> 1.%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
> distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> 
> 2.BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
> -n)
> 
> 3.
> rm -rf $RPM_BUILD_ROOT( in %install section)
> 
> 4.
> %clean
> rm -rf $RPM_BUILD_ROOT

You are right. I've removed them all.

> 
> > > 4.
> > > 
> > > Provides: dpkt = 1.7-3
> > > Obsoletes: dpkt < 1.7-3
> > > ->
> > > Obsoletes: dpkt < 1.7-4
> > > 
> > > Since dpkt is a new package, we can safely remove provides here.
> > I have no plans to touch the already published F13 update so I think the
> > Provides should stay. and it makes rpmlint happy. Change both to 1.7-4
> 
> rpmlint is wrong, except there are already some packages depends on dpkt, you
> can remove provides to save a namespace in rpmdb.
> 
> See
> http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages    

This only takes in account the packages in the disrto. For a library type
package you can't really know if some user outside the tree might not be
depending on the stable package names. 
Granted for dpkt this is unlikely at this point. I've removed the Provides.

New
Spec URL: http://declera.com/~yaneti/python-dpkt/python-dpkt.spec
SRPM URL: http://declera.com/~yaneti/python-dpkt/python-dpkt-1.7-1.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.