[Bug 616251] Review Request: uptrack - Client for the Ksplice Uptrack rebootless kernel update service

bugzilla at redhat.com bugzilla at redhat.com
Wed Jul 28 20:45:14 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=616251

Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tcallawa at redhat.com

--- Comment #1 from Tom "spot" Callaway <tcallawa at redhat.com> 2010-07-28 16:45:12 EDT ---
perl -0pe 's/^(\s+)main\(\)$/\1PackageKitYumBackend.rebootpkgs = tuple(p for p
in PackageKitYumBackend.rebootpkgs if not p.startswith("kernel"))\n$&/m or die'
/usr/share/PackageKit/helpers/yum/yumBackend.py >yumBackend.py.ksplice

...

# Install our version of the yum PackageKit backend
mkdir -p $RPM_BUILD_ROOT%{_datadir}/PackageKit/helpers/yum
install -p -m 755 yumBackend.py.ksplice
$RPM_BUILD_ROOT%{_datadir}/PackageKit/helpers/yum

You're overwriting part of PackageKit? That's not acceptable. Is this essential
to the functionality of uptrack? It looks like you're just pulling "kernel" out
of the list of packages that require a reboot.

While uptrack may be able to patch the kernel in place, should a user wish to
upgrade to the Fedora kernel rpm as is, we don't want to skip the reboot.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list