[Bug 616193] Review Request: freerdp - X Remote Desktop Protocol Client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=616193

--- Comment #4 from Christoph Wickert <cwickert at fedoraproject.org> 2010-07-28 19:59:39 EDT ---
I have already answered to your comments in bug 603481, but just for the
record. I'm leaving out the parts where I agree.

(In reply to comment #3)
> The project as whole is GPLv2+ even though some parts "just" are
> GPL-compatible. (Just like glibc doesn't mention BSD despite
> /usr/share/doc/glibc-2.12/LICENSES.)

I was under the impression that certain libs were BSD (only). As soon as
something BSD licensed builds into a separate library or binary, BSD must be
mentioned explicitly. AFAICS this is the case here.

> Actually, FreeRDP is the project, libfreerdp is the library, and xfreerdp is
> the X client. (I have tried to convince upstream to create a simple client on
> each platform and call it freerdp but haven't succeeded yet.) The way it is I
> think it would be least confusing if the package was called xfreerdp like the
> binary.

See my comment in bug 603481.

> It is mostly the core freerdp lib, so shouldn't it be called something with lib
> instead?

Not sure, it also includes the keyboard definitions.

> I also find it confusing that the -devel package is for a -common package.

Huh?
> > sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool
> > sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
> 
> Are they really needed? AFAICS my packages without this hack don't have any
> issues.

I'm getting rpaths when I build this locally, this doesn't happen in koji or
mock tough.

> > make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'
> 
> AFAIK -p isn't required by the guidelines. Just doing it on the packages where
> the maintainer cares seems a bit odd.

The guidelines mention to preserve timestamps. Things like the keyboard
defintions that are not getting compiled should IMHO have the upstream
timestamp.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.