[Bug 609079] Review Request: R-GenomicRanges - Representation and manipulation of genomic intervals

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=609079

Sandro Mathys <sm at sandro-mathys.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |sm at sandro-mathys.ch
               Flag|                            |fedora-review+

--- Comment #7 from Sandro Mathys <sm at sandro-mathys.ch> 2010-07-29 05:20:48 EDT ---
* Latest version packaged
45a675329669f420c16cb56ac02335a2680b9f29  GenomicRanges_1.0.7.tar.gz
45a675329669f420c16cb56ac02335a2680b9f29 
/home/packager/rpmbuild/SOURCES/GenomicRanges_1.0.7.tar.gz
* sha1sum are equals
! Not all mandatory Requires are present

Please change R to R-core in the Provides. Also, in the BuildRequires it
doesn't really make sense to have R and R-devel listed as R is simply a meta
package for R-devel.

* All required BuildRequires are present
* The macro %check is present
* There is 1 %dir
  %dir is OK
* There is 3 %doc
  %doc is OK
* The rpm installed in _libdir
* The rpm uses %{_libdir} and is arch
* The rpm seems to have the required element in %install
LANG=C rpmbuild -ba /home/packager/rpmbuild/SPECS/R-GenomicRanges.spec >
R-GenomicRanges.spec-build.log 2>&1
* Build properly under 2.6.32.16-141.fc12.i686.PAE
* rpmlint:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Scratch build on koji for target f14
* Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2356597
   0 free  0 open  3 done  0 failed
   2356597 build (dist-f14, R-GenomicRanges-1.0.7-1.fc13.src.rpm) completed
successfully

* Build is clean from warnings or errors
* All checks are passed
* License is OK

I trust you can fix the above before adding it to the CVS, therefore this is

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.