[Bug 618268] Review Request: geronimo-osgi-support - OSGI spec bundle support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=618268

--- Comment #4 from Chris Spike <chris.spike at arcor.de> 2010-07-29 05:57:33 EDT ---
(In reply to comment #3)
> NEEDSWORK: rpmlint must be run on every package. The output should be posted 

> spelling is not a problem, but those LICENSE EOLs and encoding are.

Done. Should be ok now:

geronimo-osgi-support.src: W: spelling-error %description -l en_US lookup ->
lockup, hookup, look up
geronimo-osgi-support.noarch: W: spelling-error %description -l en_US lookup ->
lockup, hookup, look up
geronimo-osgi-support.noarch: W: non-conffile-in-etc
/etc/maven/fragments/geronimo-osgi-support
3 packages and 1 specfiles checked; 0 errors, 3 warnings.


> NEEDSWORK: The License field in the package spec file must match the actual
> license.
> 
> License file actually contains 2 licenses: ASL and W3C, please state
> them both

Done

> Other:
>  * please comment on patches used. For example itests were removed
>  because of more depdencies that would need to be packaged. It makes
> maintenance a bit easier in the future    

Done

New spec file and SRPM:
http://spike.fedorapeople.org/geronimo-osgi-support/geronimo-osgi-support.spec
http://spike.fedorapeople.org/geronimo-osgi-support/geronimo-osgi-support-1.0-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.