[Bug 590244] Review Request: pinta - Simple Paint Application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590244

--- Comment #8 from Andrea Musuruane <musuruan at gmail.com> 2010-07-29 10:06:58 EDT ---
* I suggest you to use desktop-file-validator instead of desktop-file-install
if no modification in the desktop file are needed:
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

* Anyway, I see from the koji build that there is a warning in the desktop file
that must be fixed: 'warning: key "MimeType" is a list and does not have a
semicolon as trailing character, fixing'. Please report this problem upstream.

* If an application installs icons into one of the subdirectories in
%{_datadir}/icons/ (such as hicolor), icon caches must be updated so that the
installed icons show up in menus right after package installation:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

* Any relevant documentation included in the source distribution should be
included in the package (e.g. readme.txt, todo.txt):
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

* If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

* You must keep a changelog even if this package is still being reviewed.

* You must BuildRequires: desktop-file-utils
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

* You must fix directory ownership. The package must Requires:
hicolor-icon-theme.

* Debian and upstream have some bugfixing patches available:
http://git.debian.org/?p=pkg-cli-apps/packages/pinta.git;a=tree;f=debian/patches;h=599486d6fcdcf4efec772299dc51b0179a77411a;hb=HEAD
https://bugs.launchpad.net/pinta

I just had a quick look at the spec file. I still have to play with it deeply.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.