[Bug 584090] Review Request: mashpodde - mashpodder is a podcatching client based on BashPodder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=584090

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |NotReady

--- Comment #9 from Michael Schwendt <mschwendt at gmail.com> 2010-07-29 10:45:18 EDT ---
Do enter your real name in bugzilla, please.    


> %post
>
> echo "For example see the files in /usr/bin/mashpodder "

RPM scriptlets really ought not print anything to stdout/stderr. There is no
guarantee that anyone will see it, and while occasionally there will be error
output that isn't supressed, nobody is expected to deal with output printed by
RPM scriptlets. Simply get rid of this %post section.


> %files
> %attr(0755, root, root) %{_bindir}/mashpodder
> %attr(0755, root, root) %{_bindir}/mashpodder/mashpodder.sh
> ...

https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
Plus: Don't over-engineer your spec files with superfluous %attr.


https://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files
You have a conflict between including /usr/bin/mashpodder recursively and
including individual files in other entries of the %files section.

And what the heck does this package try to do anyway? It creates a directory in
/usr/bin and stores data/config/example files in there? Plus, the base shell
script is stored outside $PATH.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.