[Bug 615554] Review Request: minitunes - A better music player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=615554

Magnus Tuominen <magnus.tuominen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus.tuominen at gmail.com
         AssignedTo|nobody at fedoraproject.org    |magnus.tuominen at gmail.com
               Flag|                            |fedora-review?

--- Comment #6 from Magnus Tuominen <magnus.tuominen at gmail.com> 2010-07-29 12:53:18 EDT ---
I can review this tomorrow, so far I can tell you this:

add 
rm -rf %{buildroot} to %install

and fix the %description to not include unnecessary spaces:


* Look them in the face. Browse your collection by artists pictures and album
covers.
* Powerful multimedia engine. Minitunes takes advantage of 
  Quicktime on the Mac, GStreamer or Xine on Linux.
* Browse folders and files. Minitunes lets you browse your music
  the way you organized it.
* Playlists made simple. Minitunes has just a single playlist.
  It's always there on the right.

rpmlint -iv /var/lib/mock/fedora-13-x86_64/result/minitunes-*
minitunes.src: I: checking
minitunes.src: W: spelling-error %description -l en_US unclutters ->
uncluttered, clutters, cluttered
The value of this tag appears to be misspelled. Please double-check.

minitunes.src: W: spelling-error %description -l en_US playlist -> play list,
play-list, playlet
The value of this tag appears to be misspelled. Please double-check.

minitunes.src: I: checking-url http://flavio.tordini.org/minitunes (timeout 10
seconds)
minitunes.src: I: checking-url
http://flavio.tordini.org/files/minitunes/minitunes-0.1.1.tar.gz (timeout 10
seconds)
minitunes.x86_64: I: checking
minitunes.x86_64: W: spelling-error %description -l en_US unclutters ->
uncluttered, clutters, cluttered
The value of this tag appears to be misspelled. Please double-check.

minitunes.x86_64: W: spelling-error %description -l en_US playlist -> play
list, play-list, playlet
The value of this tag appears to be misspelled. Please double-check.

minitunes.x86_64: I: checking-url http://flavio.tordini.org/minitunes (timeout
10 seconds)
minitunes.x86_64: W: no-manual-page-for-binary minitunes
Each executable in standard binary directories should have a man page.

minitunes-debuginfo.x86_64: I: checking
minitunes-debuginfo.x86_64: I: checking-url http://flavio.tordini.org/minitunes
(timeout 10 seconds)
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

The spelling errors can be ignored, there are none.
I'll do a full review tomorrow.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.