[Bug 617592] Review Request: libaccounts-qt - Library for handling the account storage

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617592

--- Comment #2 from Chen Lei <supercyper1 at gmail.com> 2010-07-29 23:11:47 EDT ---
(In reply to comment #1)
> Hi Chen Lei,
> 
> here are some quick comments:
> 
> - since the name of the upstream project and the tarball is 'accounts-qt', the
> package should get this name too
> 
I suggest to call it accounts-qt, because it's a meego-specfic package and also
don't release any tarballs publicly. It'll be better to keep what upstream
calls, also we also have libaccounts-glib in fedora.

Keeping the same name with upstream is helpful, I use it to compare the version
of all meego related packages between Fedora Rawhide and Meego Trunk. 

> 
> - the doxygen docs should go to %{_defaultdocdir}/%{name}-%{version}/
> 

libaccounts-qt also provides .qch docs which is used by assitant. Install .qch
files to version doc directories is unacceptable which will break bookmarks
when updating libaccounts-qt. It may be better to simply delete html docs which
provides the same contents with .qch files.

What's your opinion?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.