[Bug 619383] Review Request: gsettings-desktop-schemas - A collection of GSettings schemas

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619383

--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-07-30 11:53:45 EDT ---
Some notes:

* EVR
  - For versioning, please use "0.0.1-Y.gitXXXXXXXX%{?dist}"
    as described in the below (this versioning method is much
    safer)
   
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Post-Release_packages

* BuildRoot
  - is no longer used on Fedora (EPEL5 and below still uses, however I
    don't think this package will be imported there)
    https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

* noarch handling
  - Maybe you want to use "%configure --libdir=%{_datadir}".

* Timestamps
  - Please consider to use
-----------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
-----------------------------------------------------------------------
    to keep timestamps on installed files as much as possible.
    This method usually works on Makefiles generated by recent
    autotools.

* %clean
  - %clean section is no longer needed on Fedora 13 and above
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
    (and I think this pakage is needed only for F-14+).

* %postun, %posttrans
  - Maybe this is better?
    http://lists.fedoraproject.org/pipermail/packaging/2010-May/007065.html
    (I don't know the current status of packaging guideline proposal
    about gsettings)

    By the way Requires(postun) or so is needed for this?

* Directory ownership issue
  - %{_datadir}/glib-2.0/schemas/ is owned by glib2 and
    it seems "Requires: glib2 (>= 2.25.x)" is needed for main
    package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.