[Bug 611454] Review Request: python-bcrypt - Python bindings for OpenBSD's Blowfish password hashing code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611454

--- Comment #5 from Thomas Spura <tomspur at fedoraproject.org> 2010-07-30 12:01:10 EDT ---
Some other comments:

- Please use the script from:
  https://fedoraproject.org/wiki/Packaging:Python
  and not just %{!?python_sitearch:....}

- Properly indentation helps to read the spec file. :)

- Vendor is still there.

- Requires: python is added automatically

- You explicitely own %{python_sitearch}/, which is not what you want.
  You want %{python_sitearch}/* instead.
  But it would be far better if you'd use something like

%{python_sitearch}/%{name}
%{python_sitearch}/%{name}-egg-info

so you know, when the egg couldn't get build (just typed it in here, untested).

- Is there a specific reason, why you use "%defattr(-, root, root, 0755)" and
not just %defattr(-,root,root,-) ?
  If not, please change it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.