[Bug 590244] Review Request: pinta - Simple Paint Application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590244

--- Comment #11 from Andrea Musuruane <musuruan at gmail.com> 2010-07-31 09:27:23 EDT ---
(In reply to comment #9)
> I fixed all problems, hope thats fine now:
> http://palango.fedorapeople.org/pinta/pinta.spec
> http://palango.fedorapeople.org/pinta/pinta-0.4-2.fc13.src.rpm

* This SRPM has not the above SPEC file in it.

* If I use the above SPEC file instead, the build will fail because your patch
for fixing the mime types in the desktop file is wrong.

The problem in the desktop file is that there is a semicolon missing at the end
of the entry "...;image/openraster" -> "...;image/openraster;". You removed all
the semicolons instead.

* Moreover your patches should have the package name in it. Usually something
like pinta-0.4-desktop-file-mime-list.patch or
pinta-desktop-file-mime-list.patch.

* After fixing the above bug and installing the rpm I hit another problem. The
/usr/bin/pinta file has the following content:

#!/bin/sh 
exec /usr/bin/mono /usr/lib/pinta/Pinta.exe "$@"

As you can see there is not way that this will work on 64 bits architectures
because they use lib64 instead of lib. Please fix this issue in %prep.

* %define installdir %{_libdir} is not needed and must be removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.