[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597967

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-06-01 02:15:19 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2221510
+ rpmlint output for SRPM and for RPM.
emacs-ibus.src: W: spelling-error %description -l en_US el -> e, l, eel
emacs-ibus.noarch: E: explicit-lib-dependency python-xlib
emacs-ibus.noarch: W: spelling-error %description -l en_US el -> e, l, eel
emacs-ibus-el.noarch: W: spelling-error Summary(en_US) Elisp -> Lisp, Elise,
Elisa
emacs-ibus-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e
lisp, Elise
emacs-ibus-el.noarch: W: no-documentation
==> All are ok to be ignored.

+ source files match upstream url (sha1sum)
c066f17640d51b91d39bffbc991f946a73469499  ibus-el-0.1.0.tar.gz
c066f17640d51b91d39bffbc991f946a73469499  ibus-el-0.1.0.tar.gz.srpm
( I see that when tried to download using wget, I get 2010-06-01 11:33:52 ERROR
403: Forbidden. Not sure why its happening but I can download it using browser)

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ emacs-ibus-el subpackage exists.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application
+ Other than requires on emacs missing, this package follows emacs addon
packaging guidelines.

Suggestions:
1) As per
https://fedoraproject.org/wiki/Packaging:Emacs#Package_Requires_and_BuildRequires,
emacs-ibus must have

Requires: emacs(bin) >= %{_emacs_version} 

2) Good if timestamps are preserved as per
http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps 


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.