[Bug 593353] Review Request: pyliblzma - Python bindings for lzma

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593353

--- Comment #2 from Dan Horák <dan at danny.cz> 2010-06-01 09:55:00 EDT ---
I've checked the latest package (please post URLs of the updated srpm too) and
there are 2 minor issues
- from rpmlint:
pyliblzma.x86_64: W: incoherent-version-in-changelog 0.5.3-1 ['0.5.3-2.fc14',
'0.5.3-2']
=> I think it's an omission

pyliblzma.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/lzma.so 0775
=> AFAIK caused by setuptools, chmod will fix it

and one more serious - licensing - the only file with a license header is
setup.py (clear LGPLv3+), but the license of the module is not so clear, the
only reference is about LGPLv3 (in setup.py and PKG-INFO) => I would say the
license of the binary package is LGPLv3. But the source files contains no
copyright or license header and this is also not optimal. Please suggest the
author to add this information.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.