[Bug 598138] Review Request: rubygem-rmail - A MIME mail parsing and generation library

bugzilla at redhat.com bugzilla at redhat.com
Tue Jun 1 17:09:42 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598138

--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-06-01 13:09:38 EDT ---
For -2:

* rubygem <-> ruby(rubygems)
  - For (Build)Requires, please choose one style (note:
    for rubygem(rake) or so, please keep this style)
    ! By the way "Requires: ruby(rubygems)" on -doc subpackage
      is not needed because -doc subpackage requires main package,
      which already has "Requires: rubygems".

* Directory ownership issue
  - %{geminstdir} itself is not owned by any packages.
  - %{gemdir}/doc itself should now owned by these packages.

* Document files
  - I think "NEWS THANKS NOTES TODO" should be in main
    package
  - I think "%doc" attribution in -doc subpackage is 
    unnecessary because the rpm name already says that it
    is for documentation.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list