[Bug 598376] Review Request: maven-one-plugin - Maven One Plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598376

--- Comment #3 from Yang Yong <yyang at redhat.com> 2010-06-01 22:18:55 EDT ---
Hi Stanislav, SPEC and SRPM are updated, please review again.

fix log:

* You need to make sure lines are not overly long (I believe they
 have to be under 80 characters. Your editor should automatically
 insert newline when editing the spec file)

FIXED

* Permissions of depmap are weird (just chmod it to 644)

FIXED

* You need to obsolete version 0:2.0.8 and provide 1:%{version}-%{release}
  your obsoletes would not obsolete current version of one plugin.

FIXED

* It would be good to put comment why test failure is ignored.
  Actually  in this case maven-one-plugin has no tests so that line
  serves no purpose. It's just causing confusion, so please remove
  it.

FIXED

* While you are at it, use xz compression for our own tarballs. It's
  smaller and fully supported. You can create them with:
  tar acf maven-one-plugin-1.2.tar.gz maven-one-plugin-1.2/

DECLINED, there is still no tar 2.x in RHEL.

* Improve summary text. It'd better if it said something like:
 "Plugin to support integration with Maven 1.x"
 "Maven One Plugin" will not tell me much when I do "yum search"... 

FIXED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.