[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599097

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #8 from Martin Gieseking <martin.gieseking at uos.de> 2010-06-04 15:17:03 EDT ---
Hi Ankur, here are some more remarks about your spec file:

- add a short comment above Patch0 telling what the patch does

- you can simplify calling the configure configure script as follows:
    echo '%{configure}' | sed '/--program-prefix=/d' >configure.new
    sh configure.new
  This also fixes the rpmlint warning about a missing libdir specification

- it's not necessary to remove the empty files as they are not listed in %doc
and thus not packaged

- drop the %doc files from the -devel package (the files should only be added
once)

- %{_includedir}/* is a bit too generic. Replace it with %{_includedir}/gexiv2/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.