[Bug 578480] Review Request: spectrum - XMPP transport/gateway

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578480

--- Comment #19 from Matej Cepl <mcepl at redhat.com> 2010-06-04 17:27:36 EDT ---
New build
http://koji.fedoraproject.org/koji/taskinfo?taskID=2230788

(In reply to comment #18)
> I see you're firmly set on having the spec file compatible with RHEL-5

Yes, because spectrum is a server application and I still hold that sane people
use RHEL/CentOS for servers (me included, and of course, I do that package for
myself in the first place ;)).

> If you
> want to be compatible, just stick with the old "_initrddir" - it's still used
> in many Fedora spec files

yes, but it is deprecated and it will be gone soon

> > License: GPLv2+ and GPLv3+
> 
> This would benefit from a comment describing which parts are under which
> licence.

fixed

> > Patch0: spectrum-without-gettext.patch
> > Patch1: spectrum-0.2-cmake.patch
> 
> All patches should have a comment (in the spec or in the patch files
> themselves) describing their purpose and upstream status.
> 
> > %if 0%{?rhel} <= 5
> > ExcludeArch: ppc
> > %endif

It's now

    %if 0%{?rhel} <= 5 && 0%{?fedora} < 7

everywhere

> First of all: Why is ppc excluded? Is it a workaround for a bug or an inherent
> incompatibility of the software with the arch?

The problem is with RHEL-5/PPC missing many packages available elsewhere (there
is no RHEL-5/PPC-Desktop and for example libpurple is a desktop package in RHEL
understanding of the world); besides, group of people longing to run spectrum
on some IBM PowerPC is so small, that I don't want to bother.

> > cat <<EOS >spectrum-logrotate
> > /var/log/spectrum/*.log {
> >     rotate 5
> >     size 1M
> >     missingok
> >     notifempty
> > }
> > EOS
> 
> I usually prefer adding such files as another Source. Whatever.

That's just a matter of preference, I like to edit as few files as possible.

> Are these problems known to upstream?

Yes, and partially fixed in git.

> > %config(noreplace) %{_sysconfdir}/spectrum/spectrum.cfg
> > %config(noreplace) %{_sysconfdir}/logrotate.d/spectrum
> 
> You should own the /etc/spectrum directory.
> You should Require logrotate because you do not own /etc/logrotate.d (and
> should not own it).    

Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.