[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599097

--- Comment #12 from Ankur Sinha <sanjay.ankur at gmail.com> 2010-06-05 02:45:36 EDT ---
(In reply to comment #11)
> You can also remove the variable definitions (CFLAGS, CXXFLAGS, FFLAGS) from
> the %build section. They are part of the %configure macro. 
> However, since I obviously was too tired yesterday, I gave you a wrong
> configure replacement (sorry for that!). The Makefile doesn't recognize the
> locally set variables. It should work with a %build section that looks like
> this:
> 
> echo '%{configure}' | sed '/--program-prefix=/d' >build.tmp
> echo 'make %{?_smp_mflags}' >>build.tmp
> sh build.tmp
> 
> 
> Since there are no empty files in the buildroot, you should really remove the
> redundant for loop. :)    

hey,

updated spec:

http://ankursinha.fedorapeople.org/libgexiv2/libgexiv2.spec

srpm:

http://ankursinha.fedorapeople.org/libgexiv2/libgexiv2-0.0.90-5.fc13.src.rpm

mock results:

http://ankursinha.fedorapeople.org/libgexiv2/

regards,
Ankur

PS : I dont understand how including the make portion(the new hack) works any
different from the earlier hack you had mentioned.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.