[Bug 581321] Review Request: perl-Devel-StackTrace-AsHTML - Displays a stack trace in HTML

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581321

Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |iarnell at gmail.com
         AssignedTo|nobody at fedoraproject.org    |iarnell at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2010-06-06 03:45:39 EDT ---
+ source files match upstream.  
    4546fa649ac59fc68d36632dd031d153  Devel-StackTrace-AsHTML-0.09.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
    GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2233157

+ package installs properly.
+ rpmlint has no meaningful complaints:
    perl-Devel-StackTrace-AsHTML.src: I: checking
    perl-Devel-StackTrace-AsHTML.src: W: spelling-error %description -l en_US
html -> HTML, ht ml, ht-ml
    perl-Devel-StackTrace-AsHTML.src: W: spelling-error %description -l en_US
WithLexicals -> Withdrawals, Athletically, Theatricals
    perl-Devel-StackTrace-AsHTML.src: I: checking-url
http://search.cpan.org/dist/Devel-StackTrace-AsHTML (timeout 10 seconds)
    perl-Devel-StackTrace-AsHTML.src: I: checking-url
http://search.cpan.org/CPAN/authors/id/M/MI/MIYAGAWA/Devel-StackTrace-AsHTML-0.09.tar.gz
(timeout 10 seconds)
    perl-Devel-StackTrace-AsHTML.noarch: I: checking
    perl-Devel-StackTrace-AsHTML.noarch: W: spelling-error %description -l
en_US html -> HTML, ht ml, ht-ml
    perl-Devel-StackTrace-AsHTML.noarch: W: spelling-error %description -l
en_US WithLexicals -> Withdrawals, Athletically, Theatricals
    perl-Devel-StackTrace-AsHTML.noarch: I: checking-url
http://search.cpan.org/dist/Devel-StackTrace-AsHTML (timeout 10 seconds)
    2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ final provides and requires are sane:
    perl(Devel::StackTrace::AsHTML) = 0.09
    perl-Devel-StackTrace-AsHTML = 0.09-1.fc14
=
    perl >= 0:5.008_001
    perl(Data::Dumper)  
    perl(Devel::StackTrace)  
    perl(:MODULE_COMPAT_5.12.0)  
    perl(Scalar::Util)  
    perl(strict)  

+ %check is present and all tests pass.
    + make test
    PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e"
"test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t
    t/00_compile.t .. ok
    t/encoding.t .... ok
    t/output.t ...... ok
    All tests successful.
    Files=3, Tests=3,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.09 cusr  0.02
csys =  0.14 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.