[Bug 578269] Review Request: xgospel - An X11 client for Internet Go Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578269

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #24 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-06-07 13:47:56 EDT ---
Well,

* BuildRoot / %clean
  - As I said above, unless you want to this package into EPEL
    BuildRoot: line is no longer needed so please remove this
    (although rpmlint may complain about it).

    https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag


* Comments for Patch0
  - So, please write some comments about what Patch0 is for
    on the above of Patch0: line like:
-----------------------------------------------------
# Fix issues when XXXXXXXXXX, fix compilation warning, etc
Patch0: xgospel-1.12d-friend.patch
-----------------------------------------------------

* parallel make
  - As I said above, please write some comments if parallel
    make fails in the spec file.
    ( Note that I have not examined how to make parallel make
      succeed for this package for now. )

* Categories for Desktop files
  - Please also remove "X-Fedora" category from desktop file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.