[Bug 592579] Review Request: Frama-c - Framework for source code analysis of C software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592579

--- Comment #25 from David A. Wheeler <dwheeler at dwheeler.com> 2010-06-07 21:47:52 EDT ---
Hooray!  Here are some quick comments from reviewing the .spec file:

Don't include no-value comments; most reviewers like .spec files to be short. 
Please remove these lines (they're all obvious in context):
#  General Information
#Build Requires Section
#Requires Section
#Arcitecure Section

This still has "plug in's", which isn't correct English.  Please use "plug-ins"
or "plug ins".

Thanks for creating the "frama-c-1.4-licensing" file.  The licensing issues
were complicated, so documenting them in one place is a real plus.

I'm glad to see the .desktop file, that's important.

The changelog at the bottom has date/time/who, but doesn't say WHAT changed.
The changelog should list, for each new version, at least one change (if there
were many, list the more important ones).  Thus, I would expect to see
something like this:
* Sun Jun 06 2010 Mark Rader <msrader at gmail.com> 1.4-3
- Added documentation to explain the various licensing entries.
- Added .desktop file

* Wed May 24 2010 Mark Rader <msrader at gmail.com> 1.4-2
- Add SELinux context settings.

* Wed Feb 10 2010 Alan Dunn <amdunn at gmail.com> 1.4-1
- Initial Fedora RPM

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.