[Bug 578480] Review Request: spectrum - XMPP transport/gateway

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578480

--- Comment #24 from Michal Schmidt <mschmidt at redhat.com> 2010-06-08 04:32:30 EDT ---
(In reply to comment #22)
> (In reply to comment #20)
> > Both approaches are acceptable in general.
> 
> I think so, I don't see any obvious packaging error in my approach. Agree?

Agreed.

> > Do you intend to support EL-4 too? If not, then it's pretty much equivalent to:
> >    %if 0%{?el5}
> 
> Except that didn't work for me on RHEL-5.

Hm, it works for me. Did you use a plain rpmbuild or mock? Both the "rhel" and
"el5" macros are defined in the package "buildsys-macros" which is installed in
the buildroot by mock (and thus in Koji too).

> > Fair enough. But I wonder if this part of the Guidelines applies then:
> > http://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Build_Failures
> 
> Yes, except I have hard time to find the good failed build. It doesn't build
> for me on F-12 (https://koji.fedoraproject.org/koji/taskinfo?taskID=2236823),
> and there are too many missing packages on RHEL-5/PPC.

I don't think you need to look for any builds. In my understanding of the
guideline it is sufficient to file a bug describing the reason for using
ExcludeArch in your package and making it block a special tracking BZ.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.