[Bug 600914] Review Request: txt2regex - Regular expression wizard that converts human sentences to regexes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600914

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2010-06-08 07:23:06 EDT ---
This would surely help with Upstream Release Monitoring... Nice program.

Review:

Good:
- sources match upstream: 83bc1f95b36fe51ade8d130fab390103
- name ok
- BR ok
- %build could be simplified, with a for loop, but ok
- locales handled properly
- no libs
- no *.la
- group ok
- %install ok
- macros everywhere
- $ rpmlint ./noarch/txt2regex-0.8-1.fc13.noarch.rpm 
txt2regex.noarch: W: spelling-error Summary(en_US) regexes -> regexps, reg
exes, reg-exes
txt2regex.noarch: W: spelling-error %description -l en_US Txt -> Tet, Ext, Tut
txt2regex.noarch: W: spelling-error %description -l en_US regex -> regexp, reg
ex, reg-ex
txt2regex.noarch: W: spelling-error %description -l en_US regexes -> regexps,
reg exes, reg-exes
txt2regex.noarch: W: spelling-error %description -l en_US softwares ->
software, software's, soft wares
txt2regex.noarch: W: spelling-error %description -l en_US egrep -> grep, egret,
e grep
txt2regex.noarch: W: spelling-error %description -l en_US lex -> ex, flex, Alex
txt2regex.noarch: W: spelling-error %description -l en_US mawk -> maw, maws,
mask
1 packages and 0 specfiles checked; 0 errors, 8 warnings.

- builds in koji:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=2237821


Needswork;
- license is unclear: The webside says GPL, the COPYING contains GPLv2.
  Is it GPLv2 only, GPLv2+ ?
  Please ask upstream to clearify this and make proper headers in a next
release.
- %desctiption:
  When searching for python or emacs or .... this program will be found, which
is not so good...
  What's your opinion towards this?


##############################################################################

Main blocker: unclear license.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.