[Bug 581619] Review Request: mlterm - Multi Lingual TERMinal emulator on X

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581619

--- Comment #13 from Hicham HAOUARI <hicham.haouari at gmail.com> 2010-06-08 07:49:40 EDT ---
1)Please provide a direct link to the spec everytime you update the package.

2)The %{_libexecdir}/* should be replaced IMHO with the corresponding files
separately.

3)You forgot to update the changelog.

4)BuildRequires : gtk+-devel, better put gtk2-devel

5)Patch should be upstreamed ( put a link to the corresponding upstream
bugzilla bug report )

6)As mentioned above, change "sed -i -re 's/#ifdef  HAVE_ISASTREAM/#ifdef
HAVE_STROPTS_H/' kiklib/src/kik_pty_streams.c" to a patch and upstream it. Same
for fribidi-config

7)The desktop file comment should be changed IMHO :
"Use the command line with Arabic support" to "Use the command line with
multilingual support", and the arabic comment also.

8)It is up to you, but the pixmapdir macro is really unneeded

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.