[Bug 600243] Review Request: libjpeg-turbo - MMX/SSE accelerated libjpeg

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600243

--- Comment #3 from Adam Tkac <atkac at redhat.com> 2010-06-09 08:06:19 EDT ---
(In reply to comment #2)
> Some trival comment:
> 1.Source0:
> http://downloads.sourceforge.net/project/libjpeg-turbo/%{version}/libjpeg-turbo-%{version}.tar.gz
> 
> ->
> Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
> 
> See http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net

Thanks for the hint, fixed.

> 2.
> Obsoletes: libjpeg < 6b-47.fc12
> Provides: libjpeg = 6b-47.fc12
> 
> Provides is not needed here.    

If I read
http://fedoraproject.org/wiki/PackageNamingGuidelines#Renaming.2Freplacing_existing_packages
correctly it is needed, isn't it?

New spec + SRPM:
http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo.spec
http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo-0.0.93-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.