[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589867

Paul Howarth <paul at city-fan.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul at city-fan.org

--- Comment #11 from Paul Howarth <paul at city-fan.org> 2010-06-10 06:19:45 EDT ---
(In reply to comment #2)
> no need to list %dir %{_datadir}/logtail, just %{_datadir}/logtail/* is enough

Not quite. You actually need:

%{_datadir}/logtail/

This includes the directory and its contents. Using just %{_datadir}/logtail/*
would mean that the package did not own the directory itself, which would be
wrong since none of the package's dependencies own it either.

Similarly you should add:
%dir %{_sysconfdir}/%{name}/
for ownership of this directory. The %dir is needed here because you want to
mark the contents of the directory as %config(noreplace).

> replace
> %{_sbindir}/logcheck
> %{_sbindir}/logtail
> %{_sbindir}/logtail2
> 
> with %{_sbindir}/*

That's a matter of style and I would personally prefer the original form.

I wouldn't use "logcheck" as the default group in %defattr as it will make it
the default group for everything, including the binaries, documentation, cron
scripts etc., which is probably not what you want.

I would have your package create and own the /var/lib/logcheck directory rather
than having useradd create it in %pre, so that the directory gets removed if
the package is removed from the system.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.