[Bug 598299] Review Request: systemd - A System and Session Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598299

--- Comment #20 from Adel Gadllah <adel.gadllah at gmail.com> 2010-06-10 15:03:46 EDT ---
(In reply to comment #18)
> I just tried the scratch build mentioned in comment 14 by installing the
> systemd RPM on my rawhide box and then naïvely rebooting and adding
> "init=/usr/bin/systemd" to the kernel command line.  Right after mounting the
> cgroup file systems it looked like systemd segfaulted and then I got a kernel
> panic.  Is there some other magic that I need to do to try out systemd or am I
> encountering an actual bug.  What's the best way to debug this problem other
> than posting screenshots of the kernel panic?    

According to Lennart a recent commit "broke everything" ... so it is a known
issue that will hopefully resolved soon.

(In reply to comment #19)
> Thanks David Hollis
> 
> http://sundaram.fedorapeople.org/packages/systemd.spec
> http://sundaram.fedorapeople.org/packages/systemd-0-0.1.20100610git2f198e.fc13.src.rpm    


----
%post
mkdir -p -m 0755 /cgroup
----

This isn't needed as the directory is created and owned by libcgroup.

-----
%global git_date    20100610
%global git_version 2f198e
%define _bindir  /bin
%define _libdir  /lib
-----

Use %global for the later two too.

rpmlint:

------
systemd.src:21: W: macro-in-comment %{name}
systemd.src:21: W: macro-in-comment %{git_version}
systemd.src:21: W: macro-in-comment %{version}
systemd.src:21: W: macro-in-comment %{git_date}
systemd.src:21: W: macro-in-comment %{git_version}
systemd.src:24: W: macro-in-comment %{name}
systemd.src:24: W: macro-in-comment %{version}
-------

Even though none of those will cause any issues; avoid any macros in comments
(multiline macros can cause all sort of weirdness).

---
systemd.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 3)
---

Either stick to spaces or tabs but don't use both.

Other than that it looks good; it builds fine there is still still some other
noise from rpmlint but it can be ignored.

Please fix the issues noted above; once you done that there shouldn't be much
blocking approval.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.