[Bug 598299] Review Request: systemd - A System and Session Manager

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 11 09:28:05 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598299

--- Comment #27 from Chen Lei <supercyper1 at gmail.com> 2010-06-11 05:28:02 EDT ---
Some trival issues that can be fixed after the feature is approved(thus upstart
should be obsoleted)

1.This package install 64bit elf files to /lib.
/lib/systemd/systemd-cgroups-agent
/lib/systemd/systemd-initctl
/lib/systemd/systemd-logger

2.I suggest not to override system rpm macros in spec, using /bin,/lib or
/%{_lib} in %file directly to keep consistency with others core packages(e.g.
glibc iptables) will be better.


3.%configure --sbindir=/sbin  --libexecdir=%{_prefix}/libexec --with-rootdir= 
--with-distro=fedora CFLAGS="%{optflags}"  

--libexecdir=%{_prefix}/libexec and CFLAGS="%{optflags}"  seems not needed.

See rpm --eval %configure

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list