[Bug 578480] Review Request: spectrum - XMPP transport/gateway

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 11 15:21:17 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578480

--- Comment #31 from Michal Schmidt <mschmidt at redhat.com> 2010-06-11 11:21:10 EDT ---
You forgot to maintain the %changelog.

rpmlint says:
> spectrum.x86_64: W: spelling-error %description -l en_US libpurple
Ignore.

> spectrum.x86_64: W: incoherent-version-in-changelog 0.3-0.git20100526.1
> ['0.3-0.3.git20100526.fc13', '0.3-0.3.git20100526']
Already noted.

> spectrum.x86_64: E: non-standard-executable-perm /usr/bin/spectrumctl 0555L
Should be 0755?

> spectrum.x86_64: E: non-readable /etc/spectrum/spectrum.cfg 0640L
The usual mode for security sensitive configs is 0600.
If it's sensitive and supposed to be readable by "spectrum", then keep it as
0640, but set its GID to "spectrum" (now its owned by root:root).
If it's not sensitive, it should be 0644.

> spectrum.x86_64: W: non-standard-uid /var/lib/spectrum spectrum
> spectrum.x86_64: W: non-standard-gid /var/lib/spectrum spectrum
Ignore.

> spectrum.x86_64: E: non-standard-dir-perm /var/lib/spectrum 0750L
Should be 0700?

> spectrum.x86_64: W: no-manual-page-for-binary spectrum
Unfortunate but not a blocker.

> spectrum.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/spectrum
> spectrum.x86_64: E: subsys-not-used /etc/rc.d/init.d/spectrum
True. And well, the initscript seems to have some more problems:
 (1) It refers to /usr/bin/spectrum which does not exist.
 (2) It executes the daemon as root.
 (3) It does not do the checks spectrumctl does before running the daemon, so
     it sometimes fails to notice errors.
Now (3) is the most difficult one of the three. In my opinion the invention of
a python program to start the daemon was a mistake done by upstream. But as
long as the necessity to use it exists, the initscript should be "fixed" to use
spectrumctl. (Note: this will also fix (2) automagically.)
Simplifying the startup mechanism to get rid of spectrumcrl usage in the
initscript can be a longer term goal (and done with upstream).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list