[Bug 505354] Review Request: php-captchaphp - PHP very user-friendly CAPTCHA solution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505354

Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tcallawa at redhat.com

--- Comment #7 from Tom "spot" Callaway <tcallawa at redhat.com> 2010-06-11 13:38:36 EDT ---
Review
=======
- rpmlint checks return:
php-captchaphp.src:6: W: macro-in-comment %{version}
php-captchaphp.src:7: W: macro-in-comment %{version}
php-captchaphp.src:8: W: macro-in-comment %{version}
php-captchaphp.src:9: W: macro-in-comment %{version}
php-captchaphp.src:9: W: macro-in-comment %{version}
php-captchaphp.src: W: invalid-url Source0: captcha-2.2.nofont.tar.gz

All safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- source matches upstream
- package compiles on F-13 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

One minor change:

Since Public Domain declarations are problematic (we don't know if the
copyright holder is able to legally put this work into the public domain), and
the copyright holder has given permission for it to be used under any FOSS
license, please adjust the licensing in the spec to this:

# Public Domain or any FOSS License, see README
# We're choosing MIT because it is universally compatible with other FOSS 
# licenses.
License: Public Domain or MIT

Make that change and I will approve this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.