[Bug 601160] Review Request: rubygem-rdiscount - Fast Implementation of Gruber's Markdown in C

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 11 17:53:47 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601160

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-06-11 13:53:44 EDT ---
For -3:

* Unneeded macro
  - %ruby_sitelib macro is used nowhere.

* Dependency for -doc subpackage
  - As I said in the previous comment, for directory (%geminstdir)
    ownership issue, -doc subpackage should have the dependency
    for main package
    ( i.e. -doc subpackage should have "R: %{name} = %{version}-%{release} )

* .gemspec
  - Move %{geminstdir}/rdiscount.gemspec to -doc subpackage.
    This one is needed only for tests.
    ( %{gemdir}/specifications/%{gemname}-%{version}.gemspec should
      stay in main package ).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list