[Bug 598688] Review Request: archivemount - FUSE based filesystem for mounting compressed archives

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598688

Mark McKinstry <mmckinst at nexcess.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmckinst at nexcess.net

--- Comment #1 from Mark McKinstry <mmckinst at nexcess.net> 2010-06-11 21:11:36 EDT ---
Niels,

I'm not an official package maintainer so this is an informal review.

archivemount.c has "This program can be distributed under the terms of the GNU
GPL" for its license. According to the GPL license included at COPYING, if no
version of the GPL is specified it can be licensed under any version. Under the
Fedora project, this short name for this license should be 'GPL+'
http://fedoraproject.org/wiki/Licensing#Good_Licenses.

You should probably remove the autom4te.cache directory that comes with the
tarball in %prep section. 

If this is going to EPEL the BuildRoot is needed, otherwise it can be left out.
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag


Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

MUST
----
[!] rpmlint must be run on every package. The output should be posted in the
review. See below
[x] The package must be named according to the Package Naming Guidelines.
[x] The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[x] The package must meet the Packaging Guidelines 
[!] The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
[x] Iff the source package includes the text of the license(s) in its own file,
then that file, containing the text of the license(s) for the package must be
included in.
[x] The spec file must be written in American English
[x] The spec file for the package MUST be legible.
[x] The sources used to build the package must match the upstream source, as
provided in the spec URL.
md5 of this tarball    : fb3ee53b1234b4cc25b5f9ad7e4e3d6d
md5 of upstream tarball: fb3ee53b1234b4cc25b5f9ad7e4e3d6d
[x] The package MUST successfully compile and build into binary rpms on at
least one primary architecture
[-] If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[x] All build dependencies must be listed in BuildRequires
[-] The spec file MUST handle locales properly
[-] Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun
[x] Packages must NOT bundle copies of system libraries
[x] If the package is designed to be relocatable, the packager must state this
fact in the request for review
[x] A package must own all directories that it creates. 
[x] A Fedora package must not list a file more than once in the spec file's
%files listings
[x] Permissions on files must be set properly
[x] Each package must consistently use macros
[x] The package must contain code, or permissable content
[-] Large documentation files must go in a -doc subpackage
[x] If a package includes something as %doc, it must not affect the runtime of
the application
[-] Header files must be in a -devel package
[-] Static libraries must be in a -static package
[-] If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package
[-] In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency
[x] Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built
[-] Packages containing GUI applications must include a %{name}.desktop file
[x] Packages must not own files or directories already owned by other packages
[x] All filenames in rpm packages must be valid UTF-8



rpmlint
-------
[mmckinst at fedora13 SRPMS]$ rpmlint archivemount-0.6.0-1.fc13.src.rpm 
archivemount.src: W: spelling-error Summary(en_US) filesystem -> file system,
file-system, falsest
archivemount.src: W: spelling-error %description -l en_US libarchive -> lib
archive, lib-archive, archive
archivemount.src: W: spelling-error %description -l en_US gz -> Hz, G, Z
archivemount.src: W: spelling-error %description -l en_US bz -> biz, NZ, bx
archivemount.src: W: spelling-error %description -l en_US filesystem -> file
system, file-system, falsest
archivemount.src: W: invalid-license GPL
1 packages and 0 specfiles checked; 0 errors, 6 warnings.
[mmckinst at fedora13 SRPMS]$

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.