[Bug 603366] Review Request: coan - re-review due to package rename from sunifdef

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603366

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review+

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2010-06-12 15:22:43 EDT ---
Review:

Good:
- name ok
- Provides/Obsoletes of the old package ok
- %build ok
- %check there
- no libs
- no .la
- license ok

Needswork:
- %files: please use %{_mandir}/man1/%{name}.1.*, so the man pages compression
can change at will.
- second paragraph in description is still "Sunifdef". Needs to be %{name}

- please use INSTALL="install -p" when installing
- the first few lines would be more readable, when name, version etc would be
properly aligned...
- removing of the excecutable bit on *.c and *.h and the for loop in %prep are
not needed anymore
- rpmlint:
$ rpmlint ./coan-4.1-1.fc13.src.rpm ./x86_64/coan-*
coan.src: W: spelling-error Summary(en_US) preprocessor -> processor,
teleprocessing, processional
coan.src: W: spelling-error %description -l en_US sunifdef -> sundries,
sunshade, Sunnite
coan.src: W: spelling-error %description -l en_US analysing -> analyzing,
analysis, analysand
coan.src: W: spelling-error %description -l en_US preprocessor -> processor,
teleprocessing, processional
coan.src: W: spelling-error %description -l en_US Sunifdef -> Sundries,
Sunshade, Sunnite
coan.src: W: spelling-error %description -l en_US ifdef -> if def, if-def,
infidel
coan.src: W: no-cleaning-of-buildroot %install
coan.src: W: no-cleaning-of-buildroot %clean
coan.src: W: no-buildroot-tag
coan.src: W: no-%clean-section
coan.x86_64: W: spelling-error Summary(en_US) preprocessor -> processor,
teleprocessing, processional
coan.x86_64: W: spelling-error %description -l en_US sunifdef -> sundries,
sunshade, Sunnite
coan.x86_64: W: spelling-error %description -l en_US analysing -> analyzing,
analysis, analysand
coan.x86_64: W: spelling-error %description -l en_US preprocessor -> processor,
teleprocessing, processional
coan.x86_64: W: spelling-error %description -l en_US Sunifdef -> Sundries,
Sunshade, Sunnite
coan.x86_64: W: spelling-error %description -l en_US ifdef -> if def, if-def,
infidel
3 packages and 0 specfiles checked; 0 errors, 16 warnings.

   ** analysing -> analyzing is a spelling error, the rest is ignorable on a
recent fedora version.


###############################################################################

The man pages compression and description change is a MUST, the other SHOULDS.
Approving, when the first two have changed (I bet you will ;)).

###############################################################################

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.